问题描述
我的代码如下.我看到了
I have my code as below. I see
public MyClass{ private static DataSource dataSource = null; private static DataSource getDataSource(){ if (dataSource == null) { try { dataSource = // something. } catch (Exception e) { // some exception. } } return dataSource; } public List doSomething(){ // ... if(dataSource == null){ dataSource = getDataSource(); } dataSource.getConnection(); // ... } }
我在声纳分析中看到以下消息.
I see following message in sonar anaylsis.
Dodgy - Write to static field from instance method This instance method writes to a static field. This is tricky to get correct if multiple instances are being manipulated, and generally bad practice. findbugs:ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD Sep12 Reliability > Architecture
我看到在这个实现中一切都很好,除了我们正在更改 doSomething 方法中的静态变量.我们如何解决这个问题?
I see everything is okay in this implementation except that we are changing the static variable in doSomething method. How do we fix this ?
推荐答案
不确定你的静态分析工具是如何工作的,但是 -
Not sure how your static analysis tool works but -
尝试通过静态设置器写入您的值:
try writing to your value via a static setter:
private synchronized static void setDataSource(DataSource ds) { dataSource = ds; }
这样你就可以了
if(dataSource == null){ setDataSource(getDataSource()); }